This repository was archived by the owner on May 15, 2026. It is now read-only.
feat: centralize model family defaults for tool preferences across all providers - #10215
Closed
ghost wants to merge 1 commit into
Closed
feat: centralize model family defaults for tool preferences across all providers#10215ghost wants to merge 1 commit into
ghost wants to merge 1 commit into
Conversation
…l providers This PR addresses Issue #10214 by creating a centralized framework for applying model family defaults to tool preferences and settings. Key changes: - Added model-family-defaults.ts with MODEL_FAMILY_REGISTRY and applyModelFamilyDefaults() - Added applyModelDefaults() helper method to BaseProvider - Updated all provider getModel() methods to apply family defaults - Removed deprecated router-tool-preferences.ts (functionality consolidated) - Added comprehensive tests for the model family defaults module Model family defaults are applied granularly: provider/model-specific settings take precedence over family defaults (only undefined properties get defaults).
Author
Review complete. No issues found. The implementation is clean and well-tested:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10214
Description
This PR attempts to address Issue #10214 by creating a centralized framework for applying model family defaults to tool preferences and settings across all providers.
Key implementation details:
New
model-family-defaults.tsmodule - ContainsMODEL_FAMILY_REGISTRYarray andapplyModelFamilyDefaults()functionBaseProvider.applyModelDefaults()helper - Protected method available to all providers extending BaseProviderUpdated all provider
getModel()methods - CallsapplyModelDefaults()to apply family-based tool preferencesRemoved
router-tool-preferences.ts- Functionality consolidated into the new centralized moduleDesign decisions:
Test Procedure
src/api/providers/utils/__tests__/model-family-defaults.spec.tsTo verify:
Pre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome. This is an initial implementation of the centralized framework for model family defaults.